Skip to content

Use Bcrypt instead of MD5/plaintext #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
vstumpf wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use Bcrypt instead of MD5/plaintext #343

vstumpf wants to merge 1 commit into from

Conversation

@vstumpf
Copy link
Member

@vstumpf vstumpf commented Mar 19, 2023 •
edited
Loading

Related to rathena/rathena#7650

We save and check bcrypt instead of MD5.
This is a breaking change, as we're forcing the use of bcrypt.

@sanasol
Copy link
Member

sanasol commented Mar 19, 2023

I think we should keep old schema for legacy users.
But make it optional and set bcrypt as new default.

And I see there is additional check for passwd_type = 2 (bcrypt + md5) that must handled also.

@vstumpf vstumpf marked this pull request as draft April 28, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstumpf @sanasol